Add centered view mode #3239

ldubos · 2022-07-29T09:07:16Z

Resolves #3203

Add a new toggle_centered_view command in Window mode and a centered-views to the editor config, change the behaviour of the recalculate function in Tree to center a View when it has the is_centered set to true to center it in the available space if the View isn't a child of a vertical container with more than 1 children.

I found that is the "standard" behaviour of the "centered mode" in most editors I use.

CptPotato · 2022-07-29T13:18:14Z

Nice!

One question though: how is the view width defined?
Looking at the diff this isn't immediately obvious to me. I personally would want to specify the width either through a setting or at runtime when calling the command.

ldubos · 2022-07-29T13:28:56Z

@CptPotato for the moment we can't define the width unfortunately I don't really know how I can make it configurable and updatable during a session, it seems really complicated, also I don't take the gutters_offset so the width = the total width not the inner width.

and I calculated the centered width like this: centered_width = min(max(available_width / 2, 120), available_width) that means if the available_width / 2 < 120 we set it to 120 and if the result is greater than the available_width we set it to available_width.

So you always have at least 120 columns (with gutters) in centered mode or the available_width / 2 if you have more space available, and the fallback is just the available space so no centering.

ShalokShalom · 2023-02-12T17:16:11Z

@ldubos I love this PR, and see that it is currently prevented from being merged by conflicts.

Do you see any chance to resolve them?

archseer · 2023-02-13T08:02:04Z

book/src/configuration.md

@@ -57,6 +57,7 @@ on unix operating systems.
 | `rulers` | List of column positions at which to display the rulers. Can be overridden by language specific `rulers` in `languages.toml` file. | `[]` |
 | `bufferline` | Renders a line at the top of the editor displaying open buffers. Can be `always`, `never` or `multiple` (only shown if more than one buffer is in use) | `never` |
 | `color-modes` | Whether to color the mode indicator with different colors depending on the mode itself | `false` |
+| `centered-views` | Wether to center views by default | `false` |


archseer · 2023-02-13T08:04:24Z

helix-term/src/commands.rs

@@ -405,6 +405,7 @@ impl MappableCommand {
        wonly, "Close windows except current",
        select_register, "Select register",
        insert_register, "Insert register",
+        toggle_centered_view, "Toggle centered view",


The naming seems confusing since the view isn't "centered" but is instead in a distraction free mode. Tmux also calls this "zoomed (in)" since the view is maximized and replaces the whole tree.

archseer · 2023-02-13T08:05:18Z

helix-view/src/view.rs

@@ -138,7 +139,7 @@ impl fmt::Debug for View {
 }

 impl View {
-    pub fn new(doc: DocumentId, gutters: GutterConfig) -> Self {
+    pub fn new(doc: DocumentId, gutters: GutterConfig, is_centered: bool) -> Self {


The default should be false and we don't want this as a part of the new() method.

archseer · 2023-02-13T08:06:35Z

helix-view/src/editor.rs

+    /// Whether to center views by default, Defaults to `false`.
+    pub centered_views: bool,


I'd remove the config option since it seems unlikely someone would want this always on.

archseer · 2023-02-13T08:11:48Z

helix-view/src/tree.rs

+                    if view.is_centered
+                        && (parent_child_count <= 1 || parent_layout != Layout::Vertical)
+                    {
+                        let width = std::cmp::min(std::cmp::max(area.width / 2, 120), area.width);
+                        let area =
+                            Rect::new(area.width / 2 - width / 2, area.y, width, area.height);
+
+                        view.area = area;
+                    } else {
+                        view.area = area;
+                    }


This gives the view the entire area but doesn't affect any of the other views. This means that you're relying on view ordering (this view should be the last one rendered) otherwise other views might get rendered over it. We also pay the performance cost of rendering all other views even though they're not on screen. (Also what happens if I change focus to a different view but this one is still centered?)

I'd rather see this done via a zoom bool flag on the tree. If set to true then the editor should just render the currently focused node and ignore the rest of the tree. The reason we haven't done this yet is because this will likely impact a bunch of other viewport calculations.

Hi, thanks for the feedback, but... to be honest I made this PR 7 months ago, so I don't remember at all why I made things in this way, and I don't have sufficent spare time to invest in this PR anymore :/ if someone is motivated enough to take over my work (or redoing it from scratch ^^') it would be better

David-Else · 2023-06-02T10:17:51Z

It would be great if someone could take over this pull request, it is so needed!

pascalkuthe · 2024-04-13T22:26:55Z

closing in favor of #9838

kirawi added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Sep 13, 2022

ldubos added 2 commits February 12, 2023 22:31

Add toggle_centered_view command and centered-views config

e27a2d0

Update docs

b785e5a

ldubos force-pushed the center-view-mode branch from 679ab27 to b785e5a Compare February 12, 2023 21:32

archseer requested changes Feb 13, 2023

View reviewed changes

gibbz00 mentioned this pull request Feb 22, 2023

(rename) View.doc -> View.doc_id #6067

Closed

ShalokShalom mentioned this pull request Mar 9, 2023

Gui #39

Closed

CBenoit added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 10, 2023

David-Else mentioned this pull request Mar 28, 2023

Golden ratio auto-resize windows #4644

Closed

the-mikedavis added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2024

lizclipse mentioned this pull request Mar 8, 2024

Added zoom & max-width #9838

Open

pascalkuthe closed this Apr 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add centered view mode #3239

Add centered view mode #3239

ldubos commented Jul 29, 2022

CptPotato commented Jul 29, 2022

ldubos commented Jul 29, 2022 •

edited

Loading

ShalokShalom commented Feb 12, 2023

archseer Feb 13, 2023

archseer Feb 13, 2023

archseer Feb 13, 2023

archseer Feb 13, 2023

archseer Feb 13, 2023

ldubos Feb 13, 2023

David-Else commented Jun 2, 2023

pascalkuthe commented Apr 13, 2024

	\| `centered-views` \| Wether to center views by default \| `false` \|
	\| `centered-views` \| Whether to center views by default \| `false` \|

		/// Whether to center views by default, Defaults to `false`.
		pub centered_views: bool,

Add centered view mode #3239

Add centered view mode #3239

Conversation

ldubos commented Jul 29, 2022

CptPotato commented Jul 29, 2022

ldubos commented Jul 29, 2022 • edited Loading

ShalokShalom commented Feb 12, 2023

archseer Feb 13, 2023

Choose a reason for hiding this comment

archseer Feb 13, 2023

Choose a reason for hiding this comment

archseer Feb 13, 2023

Choose a reason for hiding this comment

archseer Feb 13, 2023

Choose a reason for hiding this comment

archseer Feb 13, 2023

Choose a reason for hiding this comment

ldubos Feb 13, 2023

Choose a reason for hiding this comment

David-Else commented Jun 2, 2023

pascalkuthe commented Apr 13, 2024

ldubos commented Jul 29, 2022 •

edited

Loading